Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fix #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justin-espedal
Copy link

@justin-espedal justin-espedal commented Sep 29, 2020

I've been able to build this just fine before, unsure when or why this suddenly became an issue.

From the commit message:

Fixed an issue whereby Windows applications that used libjpeg-turbo would
fail to compile if the Windows system headers were included before jpeglib.h.
This issue was caused by a conflict in the definition of the INT32 type.

libjpeg-turbo/libjpeg-turbo@eed0861

Fixed an issue whereby Windows applications that used libjpeg-turbo would
fail to compile if the Windows system headers were included before jpeglib.h.
This issue was caused by a conflict in the definition of the INT32 type.

libjpeg-turbo/libjpeg-turbo@eed0861
@justin-espedal
Copy link
Author

Never mind, I found where the issue started.

I updated my copy of Hashlink to 1.11. I didn't apply the Lime-specific changes to hl.h when I did so. The HaxeFoundation version of hl.h has #include <Windows.h>, but that's commented out on Lime's side. Apparently that include causes this issue.

https://github.com/HaxeFoundation/hashlink/blob/bcbaaddc7433341b1e4813e2c6b8d913db2a02b1/src/hl.h#L212

https://github.com/haxelime/lime/blob/499a28f949ad5a8865708e143fa22cbc7dc4c57d/project/include/hl.h#L214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant