Skip to content

Conversation

@alexbozhenko
Copy link
Member

@alexbozhenko alexbozhenko commented Sep 24, 2025

Automate copying over the file, as requested by a customer in:
#1032

It is based on:
https://github.com/ConnectEverything/client-tools/blob/main/.github/workflows/version-update.yaml

@samuelattwood knows why we need a copy in this repo.

Reproducible test plan:

Reverted to previous version

#  git checkout 85ea6b9 -- helm/charts/nack/crds/crds.yml helm/charts/nack/Chart.yaml

Then tested using act(https://github.com/nektos/act):
It did the change, but failed to create a PR(which is expected)

act workflow_dispatch --workflows .github/workflows/update-nack-crds.yaml -P ubuntu-latest=catthehacker/ubuntu:act-latest --container-architecture linux/amd64 --reuse

Tested the change is right:

# docker exec -it  act-Update-NACK-CRDs-Update-NACK-CRDs-58d0c01c3a02e4abe72fee8c2eb8adf8dc1aaaa8be4ac08192e414c9f588f6d7  /bin/bash

And then expected contents of the container:

root@omenlaptop:/home/alex/code/synadia/k8s# git diff
diff --git a/helm/charts/nack/Chart.yaml b/helm/charts/nack/Chart.yaml
index 026a96d..fa20122 100755
--- a/helm/charts/nack/Chart.yaml
+++ b/helm/charts/nack/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: nack
-version: 0.29.1
-appVersion: "0.19.0"
+version: 0.29.2
+appVersion: 0.19.2
 description: A Helm chart for NACK - NAts Controller for Kubernetes
 keywords:
 - nats
diff --git a/helm/charts/nack/crds/crds.yml b/helm/charts/nack/crds/crds.yml
index a4999b5..43036d8 100644
--- a/helm/charts/nack/crds/crds.yml
+++ b/helm/charts/nack/crds/crds.yml
@@ -232,6 +232,14 @@ spec:
                 description: When true, enables direct access to messages from the origin stream.
                 type: boolean
                 default: false
+              allowMsgTtl:
+                description: When true, allows header initiated per-message TTLs. If disabled, then the `NATS-TTL` header will be ignored.
+                type: boolean
+                default: false
+              subjectDeleteMarkerTtl:
+                description: Enables and sets a duration for adding server markers for delete, purge and max age limits.
+                type: string
+                default: ''
               consumerLimits:

@samuelattwood
Copy link
Member

I don't really think this needs to be on a daily cron. The CRDs do not change very often, if we want to automate it I think I would prefer having a trigger based on that file getting changed rather than just a daily poll.

@alexbozhenko
Copy link
Member Author

alexbozhenko commented Sep 24, 2025

@samuelattwood the whole point is for humans to have one less thing to worry about.
What are the disadvantages of daily cron, that will open a PR only if there is a new release?
If there are no new releases, and local file is up to date, no PR will be created.

@samuelattwood
Copy link
Member

@alexbozhenko I think the method in #1076 is a preferable approach to a daily cron

@alexbozhenko
Copy link
Member Author

Closing. Superceded by it //github.com//pull/1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants