-
Notifications
You must be signed in to change notification settings - Fork 361
Add helm chart for managing NACK resources. #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @wallyqs @samuelattwood |
|
@wallyqs @samuelattwood any feedback here? |
| enabled: true | ||
|
|
||
| # No streams created by default. Uncomment & edit an item below. | ||
| streams: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Using lists makes it hard to override things when using multiple value inputs and can easily result in accidental removal of items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Using lists makes it hard to override things when using multiple value inputs and can easily result in accidental removal of items.
@kejne thanks for the feedback. What is the best alternative here, using a map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Something like this (You do limit the name of the stream in this case, but you can also add name as a field within that object). This allows for overriding of specific streams if that is needed.
streams:
mystream:
subjects:
- mysub.>
myotherstream:
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Something like this (You do limit the name of the stream in this case, but you can also add name as a field within that object). This allows for overriding of specific streams if that is needed.
Thanks @kejne . I got your point. That would be much better.
Summary
As proposed here add a Helm chart for NACK JetStream resources that renders Kubernetes Custom Resources (CRs) for:
Stream (streams.jetstream.nats.io)
Consumer (consumers.jetstream.nats.io)
KeyValue (keyvalues.jetstream.nats.io)
ObjectStore (objectstores.jetstream.nats.io)
It separates from the NACK controller chart to keep controller lifecycle independent from application resources.
What this PR includes
A new application chart (e.g., charts/jetstream-resources/) with:
Templates
templates/streams.yaml — loops over values.streams[]
templates/consumers.yaml — loops over values.consumers[]
templates/keyvalues.yaml — loops over values.keyValues[]
templates/objects.yaml — loops over values.objectStores[]
Values schema (high-level)
Example Usage