[FIXED] Added missing NATS_EXTERN on some functions.
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely `nats_OpenWithConfig` and `natsConnection_Reconnect`. Also normalized the `NATS_EXTER <return type>` in one line and the function name on the next line. Updated the C++ compile test since it was failing on my mac env, and modified `nats_StringEquals` that was triggering a warning on my Windows VM build. Resolves #835 Signed-off-by: Ivan Kozlovic <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 68.71% 70.45% +1.74%
==========================================
Files 39 47 +8
Lines 15207 15389 +182
Branches 3143 3155 +12
==========================================
+ Hits 10449 10843 +394
+ Misses 1700 1509 -191
+ Partials 3058 3037 -21 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2025
…some functions. (#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely
nats_OpenWithConfigandnatsConnection_Reconnect.Also normalized the
NATS_EXTERN <return type>in one line and the function name on the next line.Updated the C++ compile test since it was failing on my mac env, and modified
nats_StringEqualsthat was triggering a warning on my Windows VM build.Resolves #835
Signed-off-by: Ivan Kozlovic [email protected]