-
Notifications
You must be signed in to change notification settings - Fork 159
[ADDED] Handler invoked when a library thread is started. #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
- Coverage 70.27% 70.24% -0.03%
==========================================
Files 48 48
Lines 17334 17357 +23
Branches 3557 3563 +6
==========================================
+ Hits 12181 12193 +12
- Misses 1727 1735 +8
- Partials 3426 3429 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2a7c6b9 to
027d419
Compare
New options `ThreadStartedHandler` and `ThreadStartedHandlerClosure` in the object `natsClientConfig` are added. The handler will be invoked when a thread created from the library is started. This can be used to further configure the thread. Resolves #956 Signed-off-by: Ivan Kozlovic <[email protected]>
027d419 to
06e99a4
Compare
mtmk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please consider minor docs typos below
Signed-off-by: Ivan Kozlovic <[email protected]>
|
@mtmk Thanks for catching this. I have made the changes. |
…add_thread_started_handler
New options
ThreadStartedHandlerandThreadStartedHandlerClosurein the objectnatsClientConfigare added. The handler will be invoked when a thread created from the library is started. This can be used to further configure the thread.Resolves #956
Signed-off-by: Ivan Kozlovic [email protected]