Skip to content

Conversation

@kozlovic
Copy link
Member

New options ThreadStartedHandler and ThreadStartedHandlerClosure in the object natsClientConfig are added. The handler will be invoked when a thread created from the library is started. This can be used to further configure the thread.

Resolves #956

Signed-off-by: Ivan Kozlovic [email protected]

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.24%. Comparing base (f70ba55) to head (6ba2a97).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/glib/glib.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   70.27%   70.24%   -0.03%     
==========================================
  Files          48       48              
  Lines       17334    17357      +23     
  Branches     3557     3563       +6     
==========================================
+ Hits        12181    12193      +12     
- Misses       1727     1735       +8     
- Partials     3426     3429       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

New options `ThreadStartedHandler` and `ThreadStartedHandlerClosure`
in the object `natsClientConfig` are added. The handler will be
invoked when a thread created from the library is started. This
can be used to further configure the thread.

Resolves #956

Signed-off-by: Ivan Kozlovic <[email protected]>
@kozlovic kozlovic force-pushed the add_thread_started_handler branch from 027d419 to 06e99a4 Compare January 7, 2026 19:47
@kozlovic kozlovic requested a review from mtmk January 7, 2026 20:01
Copy link
Member

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please consider minor docs typos below

Signed-off-by: Ivan Kozlovic <[email protected]>
@kozlovic
Copy link
Member Author

kozlovic commented Jan 7, 2026

@mtmk Thanks for catching this. I have made the changes.

@kozlovic kozlovic merged commit 21ecd48 into main Jan 7, 2026
28 checks passed
@kozlovic kozlovic deleted the add_thread_started_handler branch January 7, 2026 21:10
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting core affinities for threadpool threads

4 participants