Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano fixes #727

Merged
merged 1 commit into from
Aug 22, 2024
Merged

nano fixes #727

merged 1 commit into from
Aug 22, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Aug 22, 2024

doc(core,jetstream): jsdoc for fields that are in nanoseconds, but where not specified in the description - jsdoc erases the type alias and marks as number

fix(services): processing_time was reported in millis instead of nanos

…ere not specified in the description - jsdoc erases the typealias and marks as number

fix(services): processing_time was reported in millis instead of nanos
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 7ba5c6e into main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants