Feature: Support adding service endpoint after construction #1274
Conversation
|
for this discussion |
|
@scottf any comments? |
| private static final String INTEGER_RE = "(-?\\d+)"; | ||
| private static final String STRING_RE = "\"(.+?)\""; | ||
| private static final String BOOLEAN_RE = "(true|false)"; | ||
| private static final String INTEGER_RE = "(-?\\d+)"; |
There was a problem hiding this comment.
Is there any way you can make functional changes without changing the formatting. This makes unnecessary changes to the code that require review, and it's changes the formatting that have been in place.
There was a problem hiding this comment.
ok - reverting the format change by intellij autoformat.
| sb.append("\n}"); | ||
| return sb.toString().replaceAll(",", ",\n "); | ||
| } | ||
|
|
||
| /** | ||
| * Appends a json field to a string builder. | ||
| * @param sb string builder | ||
| * |
There was a problem hiding this comment.
This is a non-essential change also and there are many of these.
| @@ -461,30 +497,25 @@ public static String getFormatted(Object o) { | |||
| indent = indent(++level); | |||
| indentNext = true; | |||
| lastWasClose = false; | |||
| } | |||
| else if (c == '}') { | |||
| } else if (c == '}') { | |||
There was a problem hiding this comment.
Definitely not. I prefer else on it's own line. It's everywhere in the code.
| ? dispatcher.subscribe(se.getSubject(), this::onMessage) | ||
| : dispatcher.subscribe(se.getSubject(), qGroup, this::onMessage); | ||
| started = DateTimeUtils.gmtNow(); | ||
| if (null == sub) { |
There was a problem hiding this comment.
please change to sub == null to be consistent with everywhere else in the code.
|
thanks @scottf, i hope all concerns have been addressed. |
|
@rexf The CLI developer suggested to change the Java client since the CLI is already out in the wild. I'll finish the review soon. |
|
@scottf done. |
rexf
force-pushed
the
feat/update_service_to_support_adding_dynamic_endpoint_after_service_construction
branch
from
47466e7 to
56edd32
Compare
|
@scottf all commit signed. thanks for the help. |
scottf
changed the title
rexf
deleted the
feat/update_service_to_support_adding_dynamic_endpoint_after_service_construction
branch
update_service_to_support_adding_endpoint_after_construction