Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Additional Try Commands to KVStore #728

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Added Additional Try Commands to KVStore #728

merged 5 commits into from
Jan 29, 2025

Conversation

darkwatchuk
Copy link
Contributor

@darkwatchuk darkwatchuk commented Jan 27, 2025 •
edited by mtmk
Loading

Added the following commands to KVStore ;

  • TryCreateAsync
  • TryUpdateAsync
  • TryDeleteAsync
  • TryPurgeAsync

@darkwatchuk
KV : Added TryPutAsync
8a9412e 
KV : Changed ValidateKey to TryValidateKey
KV : Exposed TryValidateKey as static NatsKVStore.IsValidKey
KV : Changed TryXXX to use TryValidateKey, key exceptions are no longer raised here.
KV : Changed TryXXX to use JSContext.TryPublishAsync
JSContext : Added TryPublishAsync
KV Tests : Changed Try_* tests to use TryPutAsync rather than TryPut
KV Tests : Added Several Key tests
mtmk
mtmk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @darkwatchuk

@mtmk mtmk merged commit daef76d into nats-io:main Jan 29, 2025
10 checks passed
mtmk added a commit that referenced this pull request Jan 29, 2025
@mtmk
Release 2.5.8-preview.1
44714d6 
* Added Additional Try Commands to KVStore (#728)
@mtmk mtmk mentioned this pull request Jan 29, 2025
Merged
mtmk added a commit that referenced this pull request Jan 29, 2025
@mtmk
Release 2.5.8-preview.1 (#730)
8021535 
* Release 2.5.8-preview.1

* Added Additional Try Commands to KVStore (#728)

* Disable obsolete warning in test
mtmk added a commit that referenced this pull request Feb 11, 2025
@mtmk
Release 2.5.8
2bda44c 
* Add service use queue group option (#734)
* Added Additional Try Commands to KVStore (#728)
@mtmk mtmk mentioned this pull request Feb 11, 2025
Merged
mtmk added a commit that referenced this pull request Feb 11, 2025
@mtmk
Release 2.5.8 (#738)
0e2e280 
* Add service use queue group option (#734)
* Added Additional Try Commands to KVStore (#728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add versions of KV commands that don't throw exceptions?
2 participants
@darkwatchuk @mtmk