Pass options for aiohttp client (websockets) #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okie JWT-auth over websockets
jegger
force-pushed
the
websocket-options
branch
from
abacd05 to
2b07945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This change allows to transparently passing aiohttp connection options to support cookie JWT-auth over websockets. We need it as we use Python to implement e2e test which covers our whole system. A part of that is to mimic a user (webbrowser) approaching NATS with a JWT in the cookie.
Is this something you're interested to have in this project? Or is there another, better way to get to my goal without modifying any code?
I am happy to adapt to a different style if required (e.g. passing only the JWT instead of all the options).
Thanks!