[ENH] topoDotprops modified #502
Conversation
|
Thanks so much @dokato. Can you remind me during the week to get the test data back up on flybrain? I didn't check yet if this is the only issue in the failures above. |
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 76.90% 76.96% +0.05%
==========================================
Files 48 48
Lines 5923 5938 +15
==========================================
+ Hits 4555 4570 +15
Misses 1368 1368
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| par_id = topo_features$Parent[[i]] | ||
| if (par_id == -1) next | ||
| pnt_idx = which(topo_features$PointNo == par_id) | ||
| vect_orientations[[i]] <- is_pointing_towards(x[pnt_idx,], x[i,], vect[i]) |
There was a problem hiding this comment.
this is direction in Euclidean sense not geodesic (across the graph). Can you help me understand why that is @dokato?
There was a problem hiding this comment.
I just figured that it's faster to compute with respect to an arbitrary point (soma in this case). Otherwise, I'd need to iterate point by point to change the orientation. I guess, as long as it's consisted it shouldn't matter too much, unless you can think of some counterexample?
Modifies topological dotprops by directing the orientation of all vectors so they always point towards soma direction.