Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScheduledJob Model #677

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Add ScheduledJob Model #677

merged 10 commits into from
Feb 4, 2025

Conversation

nopg
Copy link
Contributor

@nopg nopg commented Jan 21, 2025

What's Changed

Adds the ScheduledJob Model to the Bootstrap integration. Allowing users to easily update times/schedules on their Jobs, which is currently a tedious task.

@nopg nopg requested review from bile0026 and a team as code owners January 21, 2025 20:48
Copy link
Contributor

@bile0026 bile0026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor edits. Would like to see more discussion around creation of scheduled jobs (likely as a future enhancement) to stay consistent with other models.

@bile0026 bile0026 requested a review from a team January 21, 2025 21:11
@bile0026 bile0026 added type: minor feature integration: bootstrap Issues/PRs for Bootstrap integration type: enhancement New feature or request labels Jan 21, 2025
@nopg nopg force-pushed the u/nopg/bootstrap-scheduled-jobs branch from 9159426 to 91cfc02 Compare January 21, 2025 21:49
@bile0026
Copy link
Contributor

Should probably also update the tests in the adapter tests for the new model.

@nopg nopg force-pushed the u/nopg/bootstrap-scheduled-jobs branch from 955ff98 to e8ba429 Compare January 28, 2025 05:20
@nopg
Copy link
Contributor Author

nopg commented Jan 28, 2025

This is not fully ready to merge, but almost there, and wanted to push these changes up with creation of the scheduled jobs.

@nopg
Copy link
Contributor Author

nopg commented Jan 29, 2025

Ready for review, however It appears the ScheduledJob.create_schedule() method was not added till Nautobot v2.2.9 (nautobot/nautobot#5942), causing the CI failure.

According to the current compatibility matrix docs, nautobot v2.1.0 is supported. Should I 'downgrade' myself using this newer create_schedule() and just use the standard ORM kwargs available in older versions?

Copy link
Contributor

@bile0026 bile0026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small update request on docs.

docs/user/integrations/bootstrap.md Outdated Show resolved Hide resolved
@nopg
Copy link
Contributor Author

nopg commented Jan 31, 2025

Updated as requested.

Copy link
Contributor

@bile0026 bile0026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 1f8c74d into develop Feb 4, 2025
15 checks passed
@jdrew82 jdrew82 deleted the u/nopg/bootstrap-scheduled-jobs branch February 4, 2025 20:55
@jdrew82 jdrew82 mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: bootstrap Issues/PRs for Bootstrap integration type: enhancement New feature or request type: minor feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants