-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ScheduledJob Model #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor edits. Would like to see more discussion around creation of scheduled jobs (likely as a future enhancement) to stay consistent with other models.
nautobot_ssot/integrations/bootstrap/diffsync/adapters/nautobot.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/bootstrap/diffsync/models/nautobot.py
Outdated
Show resolved
Hide resolved
9159426
to
91cfc02
Compare
Should probably also update the tests in the adapter tests for the new model. |
955ff98
to
e8ba429
Compare
This is not fully ready to merge, but almost there, and wanted to push these changes up with creation of the scheduled jobs. |
Ready for review, however It appears the According to the current compatibility matrix docs, nautobot v2.1.0 is supported. Should I 'downgrade' myself using this newer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small update request on docs.
Updated as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's Changed
Adds the ScheduledJob Model to the Bootstrap integration. Allowing users to easily update times/schedules on their Jobs, which is currently a tedious task.