Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metadata to DNA Center Integration #688

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Add Metadata to DNA Center Integration #688

wants to merge 12 commits into from
+321 −17

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Feb 3, 2025 •
edited
Loading

Closes: #632

What's Changed

This PR adds support for the Object Metadata feature that was added in Nautobot 2.3 to the DNA Center integration. The following additions have been made:

MetadataType

metadate_type

Location Metadata

location_metadata

Device Metadata

device_metadata

Prefix Metadata

prefix_metadata

IPAddress Metadata

ipaddr_metadata

To Do

  • Add the same functionality to the remaining integrations.
  • Will need to add unit tests to cover this once we have CI using 2.3+.
  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • [] Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@jdrew82 jdrew82 added type: enhancement New feature or request integration: dna center Issues/PRs for Cisco DNA Center integration. labels Feb 3, 2025
@jdrew82 jdrew82 self-assigned this Feb 3, 2025
@jdrew82 jdrew82 requested a review from a team as a code owner February 3, 2025 17:06
@jdrew82 jdrew82 linked an issue Feb 3, 2025 that may be closed by this pull request
Leverage the Metadata feature to allow advanced data governance #632
Open
@glennmatthews
Copy link
Contributor

Looks real promising!

Kircheneer
Kircheneer requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I just have the one minor thing.

nautobot_ssot/integrations/dna_center/utils/nautobot.py
Returns:
ObjectMetadata: Metadata object that is created or updated.
"""
if METADATA_FOUND:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we turn this one around so it is a guard clause, like

if not METADATA_FOUND:
    continue

I prefer it this way, because its less indentation context to keep in mind when reading the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kircheneer Kircheneer Kircheneer requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jdrew82 jdrew82

Labels
integration: dna center Issues/PRs for Cisco DNA Center integration. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leverage the Metadata feature to allow advanced data governance
3 participants
@jdrew82 @glennmatthews @Kircheneer