feat(infra): add Cloud SQL with VPC peering for preview environments #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
msantoroks
commented
Dec 8, 2025
msantoroks
commented
- Manage Cloud SQL instances for dev and prod (preview uses dev via peering)
- Auto-generate passwords and store in Secret Manager
- Configure minimal resources for testing
- Implement bidirectional VPC peering between preview and dev
- Organize VPC peering configuration in vpc.tf
- Manage Cloud SQL instances for dev and prod (preview uses dev via peering) - Auto-generate passwords and store in Secret Manager - Configure minimal resources for testing - Implement bidirectional VPC peering between preview and dev - Organize VPC peering configuration in vpc.tf
msantoroks
temporarily deployed
to
preview-pr-126
GitHub Actions
Inactive
- Dev: db-custom-2-3840 (2 vCPUs, 3.75GB RAM, 50GB storage) - Prod: db-custom-4-7680 (4 vCPUs, 7.5GB RAM, 100GB storage) - Enable backups, PITR, and deletion protection for prod
Preview Deployment CompleteInfrastructure deployed to preview-pr-126 environment. Access URLs
Note: Custom domain not configured for preview environments. Use Cloud Run URL to access the application. |
Preview Deployment CompleteInfrastructure deployed to preview-pr-126 environment. Access URLs
Note: Custom domain not configured for preview environments. Use Cloud Run URL to access the application. |
fg-nava
reviewed
Dec 8, 2025
Comment on lines
+332
to
+348
| # Reverse peering from dev to preview environments | ||
| # This completes the bidirectional peering connection | ||
| resource "google_compute_network_peering" "dev_to_preview" { | ||
| for_each = var.environment == "dev" ? var.preview_vpc_names : toset([]) | ||
| name = "dev-to-preview-peering-${replace(each.value, "labs-asp-vpc-", "")}" | ||
| network = google_compute_network.main.id | ||
| peer_network = data.google_compute_network.preview_vpcs[each.value].id | ||
|
|
||
| import_custom_routes = true | ||
| export_custom_routes = true | ||
|
|
||
| depends_on = [ | ||
| google_compute_network.main, | ||
| google_service_networking_connection.private_vpc_connection | ||
| ] | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm not clear why you are using VPC peering at all. Can't the Cloud SQL instance authorize a specific CIDR ranges. Since preview uses 10.1.0.0/16, why not just add that to the Cloud SQL's authorized networks?
With the current setup I think we would have to manage the dev->preview VPC connection as well right?
I might be a bit ignorant here, anything you can share about why bidirectional VPC peering is a good idea might help me understand better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.