refactor: apply cfcs to ngx-imready #36
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This applies @cfcs/angular to ngx-imready.
The props of ImReady that Angular uses as inputs do not yet have values at the time the reactive ImReady instance is created.
So I declared an internal method
setProps
and use in ngAfterViewInit to put the props values into the instance.Is there a better suggestion for implementing this?