✨ Combobox #1868
Merged
✨ Combobox #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected options
Handle open/close dropdown on focus/blur for the entire component, not at each interactive element inside it. This works because events bubble up, causing onFocus/onBlur on outer div to be called.
…ted the combobox component so it temporarily lost focus from the input field.
…led by Chips component.
… avoid "jumping" keyboard and component
# Conflicts: # yarn.lock
…where autocomplete breaks and adds the beginning of the word after a few letters have been typed
…enter) on mobile keyboard
…ield is cleared on enter/OK on mobile
… text using "enter" on mobile keyboards. The actual issue was that capitalized words broke an equality check, causing us to try to add a new value. Since that wasn't active on single select example, we just cleared the field and moved on.
…e width and just breaking to a new line when the space becomes too small.
…m" and size="small"
Should be last adjustment for size="small"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.