[Ny komponent] Stack, Spacer #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdb4ab1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
JulianNymark
previously approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Da jeg testet så jeg ikke noe galt! 🎉 , nice med Layout componenter. Eneste er om vi burde legge til mer en placeholder firkanter? Er kanskje greit slik det er 🤔 (utviklere skjønner det nok). Evt. en story control / demo eksempel for å bytte ut placeholder med en Nå har vi jo <TextField> eller <BodyLong>.<Skeleton> vi kunne brukt for å dra fokus vekk i fra "content" (Lorem) og mer på selve layout! 💡
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/navikt/projects/49?query=is%3Aopen+sort%3Aupdated-desc&pane=issue&itemId=24132980
Closes aksel#189
Stack bruker nå
gapfor spacing. Dette brakk bruk av<Spacer />som da endte opp med å gi dobbel gap mellom elementene. Ble løst med å bruke "bleed"-teknikk på spacer.Diskusjon
wrapvære defaulttrue?layout.css. Dette vil være mest relevant for "superbrukere" som ikke bare laster inn hele CSS-en fra Aksel, men bare de delene de mener er relevante