Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Dropdown: Better Item examples #2072

Merged
merged 1 commit into from
Jun 22, 2023
Merged

📝 Dropdown: Better Item examples #2072

merged 1 commit into from
Jun 22, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Jun 22, 2023

Forslag til forbedring (?) av kode-eksempelet for Dropdown.

Det virker som at ikke alle får meg seg at Dropdown.Menu.GroupedList.Item er en <button> som standard, og at man derfor ikke kan ha lenker inni den. (Det står under Props, men mange kopierer sikkert bare eksempel-koden.) Har derfor oppdatert eksempelet slik at de trolig vanligste brukstilfellene kommer fram.

https://nav-it.slack.com/archives/C7NE7A8UF/p1687430929786099

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

⚠️ No Changeset found

Latest commit: 6894fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@KenAJoh KenAJoh merged commit 60f64d7 into main Jun 22, 2023
@KenAJoh KenAJoh deleted the dropdown-item-example branch June 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants