Tailwind: Fixed 'screen' -> 'screens' bug to properly adopt breakpoints. #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenAJoh
added
klar for gjennomgang 🔍
Aksel-V7
🦋 Changeset detectedLatest commit: de3e561 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HalvorHaugan
added a commit
that referenced
this pull request
Sep 13, 2024
* Tooltip labeling (#3094) * feat: Better labeling of Tooltip * feat: Better keyshortcuts for screenreaders in Tooltip * memo: Updated story * bug: Better error logging for example-parsing * refactor: describeChild -> describesChild * fire: Removed extra story * bug: removed extra tabIndex * memo: Update Tooltip demo description * Update aksel.nav.no/website/pages/eksempler/tooltip/labeling.tsx Co-authored-by: Halvor Haugan <[email protected]> * refactor: Updated defaultValue for describesChild * bug: removed Tooltip prop from ToggleGroup --------- Co-authored-by: Halvor Haugan <[email protected]> * Tailwind: Fixed 'screen' -> 'screens' bug to properly adopt breakpoints. (#3119) * 💥 Screen -> Screens in tailwind-config * refactor: Adopt updated screens-config in Aksel.nav.no project * Icons: Removed old and renamed icons (#3120) * 💥 Removed renamed icons * ErrorSummary: Add fallback for heading + better focus handling (#3140) Co-authored-by: Ken <[email protected]> Co-authored-by: Ken <[email protected]> Co-authored-by: Halvor Haugan <[email protected]> * feat: Added composeEventHandlers to onFocus in ErrorSummary * memo: Removed inaccurate description for tooltip demo * feat: Omitted tabIndex from ErrorSummary --------- Co-authored-by: Ken <[email protected]> Co-authored-by: Ken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Someone (me) can't type properly and as a consequence our tailwind-config did not properly adopt the 'screens' config for breakpoints added 1+ year ago.
Why is this a breaking change?
Every project using tailwind will have used these values for their breakpoints before. By changing to our breakpoints with this change,
smwill now be480pxand2xlwill be1440px.2xlchange since one seldom use that breakpointsm-change. In most cases this will not actually require a code update on their side, but will need each project to check that everything still looks as it should. Worst case scenario might be elements not wrapping properly 🤔 The change itself is only a 160px difference, so the possibility for actual breaking changes are few.Nice thing about the update is that each project can override this themselves by just adding two lines of code in their config. This allows them to update to next major without actually using this update. Since each project using tailwind already have a config, this will be quite easy to adopt.