Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation demo improvements #3132

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Sep 6, 2024

  • Added block padding by adding a variant called "static-full" to withDsExample. Refactored a bit while I was at it.
  • Added htmlSize={11} to pnr-field to follow guideline about field width.
  • Removed <Page> bc. it's not needed.
  • Removed as="main" since demos does not contain everything you would expect to find in <main>.

Tip: Turn on "Hide whitespace" when reviewing the code.

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: 992df7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Storybook demo

Endringer til review: 2

27a8b8b71 | 90 komponenter | 141 stories

@HalvorHaugan HalvorHaugan merged commit 1d585e6 into main Sep 9, 2024
5 checks passed
@HalvorHaugan HalvorHaugan deleted the formval-demo-improvements branch September 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants