Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aksel.nav.no, Button docs] Renamed 'frameworks' example to 'button as link'. #3135

Merged
merged 6 commits into from
Sep 10, 2024
Merged

[Aksel.nav.no, Button docs] Renamed 'frameworks' example to 'button as link'. #3135

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c3173a
memo: Updated storyname for button framework
KenAJoh Sep 6, 2024
a0e25fe
memo: Updated example with link i description and link -> nextlink
KenAJoh Sep 9, 2024
243e9de
testing: Added test to check link/markdown-parsing in description-field
KenAJoh Sep 9, 2024
3491e0d
test for playwright
KenAJoh Sep 9, 2024
66e116c
bug: Playroom does not support Nextjs link
KenAJoh Sep 9, 2024
4493554
bug: Turn off sandbox for bytton-demo missing import in playroom
KenAJoh Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ite/pages/eksempler/button/frameworks.tsx → ...pages/eksempler/button/button-as-link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import Link from "next/link";
import NextLink from "next/link";
import { Button } from "@navikt/ds-react";
import { withDsExample } from "@/web/examples/withDsExample";

const Example = () => {
return (
<Link href="#" passHref legacyBehavior>
<NextLink href="#" passHref legacyBehavior>
<Button as="a">Lenke</Button>
</Link>
</NextLink>
);
};

Expand Down Expand Up @@ -38,5 +38,5 @@ export const Demo = {

export const args = {
index: 10,
desc: "OverridableComponent lar deg endre hvilken html-tag komponenten rendres med.",
desc: "[OverridableComponent](https://aksel.nav.no/grunnleggende/kode/overridablecomponent) lar deg endre hvilken html-tag komponenten rendres med. For vanlige lenker kan dette være en `<a>`-tag, men for f.eks React Router eller Remix kan det være en `<Link>`-komponent.",
};
Loading