Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 tweak CSS for list icons #3148

Merged
merged 5 commits into from
Sep 13, 2024
Merged

💄 tweak CSS for list icons #3148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c07736
:lipstick: tweak CSS for list icons + safari CSS hack
JulianNymark Sep 11, 2024
0d25889
:art: use font-size to adjust icon size
JulianNymark Sep 12, 2024
79616a7
:fire: remove ugly CSS hack
JulianNymark Sep 12, 2024
5fef020
Merge branch 'main' into list-tweaks-icon-and-safari
JulianNymark Sep 12, 2024
2d82337
:memo: changeset
JulianNymark Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-kangaroos-visit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@navikt/ds-css": patch
---

List: :lipstick: make icons 24x24px large
1 change: 1 addition & 0 deletions @navikt/core/css/list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
align-items: center;
height: var(--a-font-line-height-xlarge);
padding-block-end: 1px;
font-size: 1.5rem;
}

.navds-list--small .navds-list__item-marker--icon {
Expand Down
13 changes: 7 additions & 6 deletions @navikt/core/react/src/list/list.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Meta, StoryObj } from "@storybook/react";
import React from "react";
import {
BabyWrappedIcon,
BrailleIcon,
CheckmarkIcon,
ForkIcon,
HeadHeartIcon,
RecycleIcon,
SplitHorizontalIcon,
} from "@navikt/aksel-icons";
import { VStack } from "../layout/stack";
import { BodyLong } from "../typography";
Expand Down Expand Up @@ -241,7 +242,7 @@ export const SizesIcons = {
export const Icons = {
render: () => {
return (
<List>
<List title="Best title">
<List.Item
title="Lorem Ipsum Dolor Sit Amet"
icon={<BrailleIcon aria-hidden />}
Expand All @@ -250,14 +251,14 @@ export const Icons = {
</List.Item>
<List.Item
title="Consectetur Adipiscing Elit"
icon={<HeadHeartIcon aria-hidden />}
icon={<ForkIcon aria-hidden />}
>
Beskrivelsen på punkter er nærmere forklart <a href="/">her</a>
</List.Item>
<List.Item icon={<BabyWrappedIcon aria-hidden />}>
<List.Item icon={<CheckmarkIcon aria-hidden />}>
Beskrivelsen på punkter er nærmere forklart <a href="/">her</a>
</List.Item>
<List.Item icon={<RecycleIcon aria-hidden />}>
<List.Item icon={<SplitHorizontalIcon aria-hidden />}>
Beskrivelsen på punkter er nærmere forklart <a href="/">her</a>
</List.Item>
</List>
Expand Down
Loading