Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal fixes #1201

Merged
merged 3 commits into from
Oct 9, 2023
Merged

modal fixes #1201

merged 3 commits into from
Oct 9, 2023

Conversation

tu55eladd
Copy link
Contributor

  • Fix scrollbar og aria-labelled-by
  • Remove unused props

@tu55eladd tu55eladd requested a review from a team as a code owner October 9, 2023 13:43
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tu55eladd tu55eladd merged commit 2341e88 into main Oct 9, 2023
3 checks passed
@tu55eladd tu55eladd deleted the modal-fixes branch October 9, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johatr johatr johatr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tu55eladd @johatr