-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAV-22311: Bestemmer arbeidsfordelingsenhet utenfor OpprettOppgave-task #4799
Merged
bragejahren
merged 10 commits into
main
from
NAV_22311/bestemmer-arbeidsfordelingsenhet-utenfor-opprett-oppgave-task
Oct 8, 2024
Merged
NAV-22311: Bestemmer arbeidsfordelingsenhet utenfor OpprettOppgave-task #4799
bragejahren
merged 10 commits into
main
from
NAV_22311/bestemmer-arbeidsfordelingsenhet-utenfor-opprett-oppgave-task
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndeEnhet fremfor i opprettOppgave. OppgaveArbeidsfordelingService -> TilpassArbeidsfordelingService.
…tenfor-opprett-oppgave-task
…tenfor-opprett-oppgave-task
UyQuangNguyen
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synes det ser bra ut! 🙌
thoalm
reviewed
Oct 7, 2024
src/main/kotlin/no/nav/familie/ba/sak/kjerne/arbeidsfordeling/TilpassArbeidsfordelingService.kt
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Oct 7, 2024
...tstester/kotlin/no/nav/familie/ba/sak/kjerne/arbeidsfordeling/ArbeidsfordelingServiceTest.kt
Outdated
Show resolved
Hide resolved
thoalm
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤩
Noen kommentarer du kan vurdere
bragejahren
deleted the
NAV_22311/bestemmer-arbeidsfordelingsenhet-utenfor-opprett-oppgave-task
branch
October 8, 2024 07:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favro: NAV-22311
💰 Hva skal gjøres, og hvorfor?
Tidligere tilpasset/justerte vi arbeidsfordeling på behandling i
OpprettOppgaveTask
slik at BehandleSak-oppgave fikk korrekt kombinasjon av enhet og saksbehandler. I og med atOpprettOppgaveTask
, kjøres asynkront, blir ikke arbeidsfordeling på behandling oppdatert før saksbehandler blir rutet til "Registrer søknad"-steget. Dette fører til at det ser ut som at behandlingen er satt på feil enhet, selv om den egentlig er riktig (dukket opp korrekt dersom saksbehandler oppdaterer siden).Tilpasser derfor arbeidsfordelingen i henhold til saksbehandlers tilganger tidligere, og utenfor
OpprettOppgaveTask
ifastsettBehandlendeEnhet
-metoden iArbeidsfordelingService
. Dette gir også mer mening da det er ifastsettBehandlendeEnhet
vi henter "geografisk behandlende enhet", som vi nå validerer tilgangen til.✅ Checklist