Fix identhendelser som feiler på dobbel lagring av aktør #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FredrikP <[email protected]>
Signed-off-by: FredrikP <[email protected]>
fredrikpf
changed the title
UyQuangNguyen
approved these changes
Oct 7, 2024
| @@ -147,7 +147,6 @@ class PersonidentService( | |||
| it.aktiv = false | |||
| it.gjelderTil = LocalDateTime.now() | |||
| } | |||
| if (lagreNyAktør) aktørIdRepository.saveAndFlush(aktør) // Må lagre her fordi unik index er en blanding av aktørid og gjelderTil, og hvis man ikke lagerer før man legger til ny, så feiler det pga indexen. | |||
|
|
|||
There was a problem hiding this comment.
Artig at man ikke trengte denne alikevel :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Hva skal gjøres, og hvorfor?
Favro
Vi har en del identhendelsetasker som feiler fordi vi lagrer ned aktør dobbelt. Går derfra vekk fra å lagre ned aktør to ganger i PersonidentService.
Bruker hentFagsakerPåPerson() i stedet for hentFagsakDeltager() siden sistnevnte gjør veldig mye mer enn å bare hente fagsakene som er gjeldende for personen.