Refaktorert Toast - Skal legge seg på midten og kunne krysses ut #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for at den ikke skal være i veien og at det skal bli mer konsist.
gunnsteingarmo
requested review from
charliemidtlyng,
ViktorGSolberg and
ma10s
…lir brukt. Alle toast skal bruke ContainerTopMiddle, trenger ikke å gjenta denne koden.
|
Ulempen med "midten av skjermen" er at den hindrer noe knappevalg - så da bør vi få på plass kryss for å kunne lukke en toast i samme slengen, tror jeg. |
gunnsteingarmo
changed the title
|
|
||
| useEffect(() => { | ||
| settSkalVise(true); | ||
| }, [children]); |
There was a problem hiding this comment.
Er det meningsbærende å ha en reactNode som avhengighet i en useEffect?
There was a problem hiding this comment.
Var ikke klar over at det er dårlig praksis. Har gjort endringer
…kal vises. Dette er for å ikke bruke reactNode som dependency i useEffekt som kan føre til uønsket oppførsel.
charliemidtlyng
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
Favro
Bildene viser at toasten legger seg på midten av skjermen og har mulighet til å krysses ut.