EY-2433: Flytte adopsjonslogikken over til etterlatte-kodebasen #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vi likt på tvers av malane, så trekkjer det ut som ein separat funksjon på toppnivå
…klassar frå samleobjektet EtterlatteBrev
…med dei nye endringane bruke ManueltBrevDTO
Watercolours
approved these changes
Jul 6, 2023
Comment on lines
+26
to
+31
| data class BarnepensjonInnvilgelseDTO( | ||
| val utbetalingsinfo: Utbetalingsinfo, | ||
| val avkortingsinfo: Avkortingsinfo? = null, | ||
| val avdoed: Avdoed | ||
| ) | ||
|
|
There was a problem hiding this comment.
Vet ikke om jeg er helt fan av å dra DTOer inn i Brevmalen 🤔
Men samtidig synes jeg det fort blir mye rot med alt i en fil (EtterlatteBrev.kt)... Kanskje heller opprtte nye filer for DTOene og la det som er felles forbli i EtterlatteBrev? Bare en tanke
There was a problem hiding this comment.
Skal røske litt meir i det her når eg tar neste runde på omgjøring av farskap snart, så ser på det da. Trur eg liker tanken på eiga fil per DTO 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.