Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saksbehandler bekrefter opprettelse av nytt brev dersom det finnes eksisterende kladd #969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions skribenten-web/frontend/cypress/e2e/brevvelger/kladd.cy.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { nyBrevInfo, nyBrevResponse } from "../../utils/brevredigeringTestUtils";

describe("Kladd", () => {
beforeEach(() => {
cy.setupSakStubs();
Expand Down Expand Up @@ -81,4 +83,72 @@ describe("Kladd", () => {
cy.wait("@getAlleBrevForSak");
cy.contains("Informasjon om saksbehandlingstid").should("not.be.visible");
});

it("bruker eksisterende kladd", () => {
cy.intercept("GET", "/bff/skribenten-backend/sak/123456/brev", (req) => {
req.reply([
nyBrevInfo({ id: 1, opprettet: "2024-09-17T08:36:09.785Z" }),
nyBrevInfo({ id: 2, opprettet: "2024-10-17T08:36:09.785Z" }),
]);
}).as("getAlleBrevForSak");
cy.intercept("GET", "/bff/skribenten-backend/brevmal/INFORMASJON_OM_SAKSBEHANDLINGSTID/modelSpecification", {
fixture: "modelSpecification.json",
});

cy.wait("@getAlleBrevForSak");
cy.contains("Informasjonsbrev").click();
cy.get("p:contains('Informasjon om saksbehandlingstid')").eq(3).click();
cy.get("select[name=enhetsId]").select("NAV Arbeid og ytelser Innlandet");
cy.get("select[name=spraak]").should("have.value", "NB");

cy.contains("Mottatt soeknad").click().type("09.10.2024");
cy.contains("Ytelse").click().type("Alderspensjon");
cy.contains("Svartid uker").click().type("4");
cy.contains("Åpne brev").click("left");

cy.contains("Vil du bruke eksisterende kladd?").should("be.visible");
cy.contains("Du har en eksisterende kladd basert på samme brevmal.").should("be.visible");
cy.contains("Lag nytt brev").should("be.visible");
cy.contains("Ja, bruk eksisterende kladd").click();
cy.url().should("eq", "http://localhost:5173/saksnummer/123456/brev/2");
});

it("lager nytt brev selv om saken har eksisterende kladd", () => {
cy.intercept("GET", "/bff/skribenten-backend/sak/123456/brev", (req) => {
req.reply([nyBrevInfo({ id: 1, opprettet: "2024-09-17T08:36:09.785Z" })]);
}).as("getAlleBrevForSak");
cy.intercept("GET", "/bff/skribenten-backend/brevmal/INFORMASJON_OM_SAKSBEHANDLINGSTID/modelSpecification", {
fixture: "modelSpecification.json",
});
cy.intercept("POST", "/bff/skribenten-backend/sak/123456/brev", (req) => {
expect(req.body).deep.equal({
brevkode: "INFORMASJON_OM_SAKSBEHANDLINGSTID",
spraak: "NB",
avsenderEnhetsId: "4405",
mottaker: null,
saksbehandlerValg: {
mottattSoeknad: "2024-10-09",
ytelse: "Alderspensjon",
svartidUker: "4",
},
});
req.reply(nyBrevResponse({ info: nyBrevInfo({ id: 2 }) }));
}).as("createBrev");

cy.wait("@getAlleBrevForSak");
cy.contains("Informasjonsbrev").click();
cy.get("p:contains('Informasjon om saksbehandlingstid')").eq(2).click();
cy.get("select[name=enhetsId]").select("NAV Arbeid og ytelser Innlandet");
cy.get("select[name=spraak]").should("have.value", "NB");

cy.contains("Mottatt soeknad").click().type("09.10.2024");
cy.contains("Ytelse").click().type("Alderspensjon");
cy.contains("Svartid uker").click().type("4");
cy.contains("Åpne brev").click("left");

cy.contains("Vil du bruke eksisterende kladd?").should("be.visible");
cy.contains("Du har en eksisterende kladd basert på samme brevmal.").should("be.visible");
cy.contains("Lag nytt brev").click();
cy.url().should("eq", "http://localhost:5173/saksnummer/123456/brev/2");
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,7 @@ export const nyBrevInfo = (args: {
brevkode: args.brevkode ?? "INFORMASJON_OM_SAKSBEHANDLINGSTID",
brevtittel: args.brevtittel ?? "Informasjon om saksbehandlingstid",
status: args.status ?? {
type: "UnderRedigering",
redigeresAv: { id: "Z990297", navn: "Sist R. av" },
type: "Kladd",
},
distribusjonstype: args.distribusjonstype ?? Distribusjonstype.SENTRALPRINT,
mottaker: args.mottaker ?? null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import { Button, HStack, VStack } from "@navikt/ds-react";
import { useMutation, useQueryClient } from "@tanstack/react-query";
import { BodyShort, Button, HStack, Modal, VStack } from "@navikt/ds-react";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { useNavigate } from "@tanstack/react-router";
import { memo, useEffect, useRef, useState } from "react";
import { memo, useEffect, useMemo, useRef, useState } from "react";
import { FormProvider, useForm } from "react-hook-form";

import { createBrev, getBrev } from "~/api/brev-queries";
import { hentAlleBrevForSak } from "~/api/sak-api-endpoints";
import { SaksbehandlerValgModelEditor } from "~/Brevredigering/ModelEditor/ModelEditor";
import { Divider } from "~/components/Divider";
import OppsummeringAvMottaker from "~/components/OppsummeringAvMottaker";
import { mapEndreMottakerValueTilMottaker } from "~/types/AdresseUtils";
import type { LetterMetadata } from "~/types/apiTypes";
import type { SpraakKode } from "~/types/apiTypes";
import type { BrevResponse, Mottaker, SaksbehandlerValg } from "~/types/brev";
import type { BrevInfo, BrevResponse, Mottaker, SaksbehandlerValg } from "~/types/brev";
import type { Nullable } from "~/types/Nullable";

import { Route } from "../../../route";
Expand All @@ -29,6 +30,47 @@ interface BrevbakerFormData {
mottaker: Nullable<Mottaker>;
}

const EksisterendeKladdModal = (props: {
åpen: boolean;
onClose: () => void;
onFormSubmit: () => void;
sisteEksisterendeKladdId: number;
}) => {
const navigate = useNavigate({ from: Route.fullPath });
return (
<Modal
header={{ heading: "Vil du bruke eksisterende kladd?" }}
onClose={props.onClose}
open={props.åpen}
portal
width={500}
>
<Modal.Body>
<BodyShort>Du har en eksisterende kladd basert på samme brevmal.</BodyShort>
</Modal.Body>
<Modal.Footer>
<HStack gap="4">
<Button onClick={props.onFormSubmit} type="button" variant="secondary">
Lag nytt brev
</Button>
<Button
onClick={() => {
navigate({
to: "/saksnummer/$saksId/brev/$brevId",
params: { brevId: props.sisteEksisterendeKladdId },
});
}}
type="button"
variant="primary"
>
Ja, bruk eksisterende kladd
</Button>
</HStack>
</Modal.Footer>
</Modal>
);
};

const BrevmalBrevbaker = (props: {
letterTemplate: LetterMetadata;
preferredLanguage: SpraakKode | null;
Expand All @@ -44,6 +86,22 @@ const BrevmalBrevbaker = (props: {
const navigate = useNavigate({ from: Route.fullPath });
const [modalÅpen, setModalÅpen] = useState<boolean>(false);
const formRef = useRef<HTMLFormElement>(null);
const [åpnerNyttBrevOgHarKladd, setÅpnerNyttBrevOgHarKladd] = useState<boolean>(false);

const alleSaksbrevQuery = useQuery({
queryKey: hentAlleBrevForSak.queryKey(props.saksId.toString()),
queryFn: () => hentAlleBrevForSak.queryFn(props.saksId.toString()),
});

const sistOpprettetKladd = useMemo(() => {
return alleSaksbrevQuery.data
?.filter((brev: BrevInfo) => brev.brevkode === props.letterTemplate.id)
.toSorted((a, b) => {
return new Date(a.opprettet).getTime() - new Date(b.opprettet).getTime();
})
.at(-1);
}, [alleSaksbrevQuery.data, props.letterTemplate.id]);
const harEksisterendeKladd = !!sistOpprettetKladd;

const opprettBrevMutation = useMutation<BrevResponse, Error, BrevbakerFormData>({
mutationFn: async (values) =>
Expand Down Expand Up @@ -73,11 +131,34 @@ const BrevmalBrevbaker = (props: {
});

useEffect(() => {
props.setOnFormSubmitClick({ onClick: () => formRef.current?.requestSubmit() });
}, [props.setOnFormSubmitClick, props]);
if (harEksisterendeKladd) {
props.setOnFormSubmitClick({
onClick: () => {
form.trigger().then((isValid) => {
if (isValid) {
setÅpnerNyttBrevOgHarKladd(true);
}
});
},
});
} else {
props.setOnFormSubmitClick({ onClick: () => formRef.current?.requestSubmit() });
}
}, [props.setOnFormSubmitClick, props, harEksisterendeKladd, form]);

return (
<VStack gap="4">
{åpnerNyttBrevOgHarKladd && (
<EksisterendeKladdModal
onClose={() => setÅpnerNyttBrevOgHarKladd(false)}
onFormSubmit={() => {
formRef.current?.requestSubmit();
setÅpnerNyttBrevOgHarKladd(false);
}}
sisteEksisterendeKladdId={sistOpprettetKladd!.id}
åpen={åpnerNyttBrevOgHarKladd}
/>
)}
<LetterTemplateHeading letterTemplate={props.letterTemplate} />
<Divider />
<FormProvider {...form}>
Expand Down