IS: Upgrade snakeyaml transitive dependency #322
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,9 +100,9 @@ dependencies { | |||
| } | |||
| } | |||
| implementation("org.yaml:snakeyaml") { | |||
| because("io.confluent:kafka-schema-registry:${Versions.confluent} -> https://advisory.checkmarx.net/advisory/vulnerability/CVE-2022-25857/") | |||
| because("io.confluent:kafka-schema-registry:${Versions.confluent} -> https://nvd.nist.gov/vuln/detail/CVE-2022-1471") | |||
There was a problem hiding this comment.
Hadde også gått an å ta bort hele denne blokken og se hvilken versjon av snakeyaml som kommer inn nå (kan godt være at det blir en nyere versjon nå enn det vi pleide å ha).
There was a problem hiding this comment.
Sjekket, og den var 1.33 fortsatt da :/
geir-waagboe
approved these changes
Oct 13, 2023
JMLindseth
approved these changes
Oct 13, 2023
andersrognstad
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈
Se https://github.com/navikt/syfooversiktsrv/security/dependabot/1 og https://nvd.nist.gov/vuln/detail/CVE-2022-1471 for sårbarhet. Det var vel en grunn til at vi var på 1.33 før, men litt usikker på hvordan jeg kan teste dette 🤔
Det er en fin kommando i gradle som heter
./gradlew -q dependencyInsight --dependency <dependency du vil sjekke>, der man kan søke opp dependency og finne versjonen vi bruker, og hvilken pakke den er transitivt koblet til 🙌🏼