Unleashklient #43
Merged
Unleashklient #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirarset
reviewed
Jan 31, 2024
Comment on lines
+34
to
+40
| fun dummyUnleashService(): UnleashService { | ||
| logger.warn( | ||
| "Funksjonsbryter-funksjonalitet er skrudd AV. " + | ||
| "isEnabled gir 'false' med mindre man har oppgitt en annen default verdi.", | ||
| ) | ||
| return DummyUnleashService() | ||
| } |
eirarset
reviewed
Jan 31, 2024
Comment on lines
+11
to
+14
| fun main() { | ||
| println(unleashService.getVariant(Toggle.ROUTING_TILSYN_BARN)) | ||
| println(unleashService.isEnabled(Toggle.ROUTING_TILSYN_BARN)) | ||
| } |
There was a problem hiding this comment.
Vil du asserte noe her? 🤔
There was a problem hiding this comment.
Det var mer en klasse for å kunne kjøre å teste variant, mest for moro :) Men tenkte den fila kunde være nyttig å bli der
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
For å kunne featuretoggle funksjonalitet.
Skal kjøre dette før jeg deployer og tester selve togglingen
I første omgang så ønsker jeg å bruke variant for å kunne sette antall personer som skal til ny søknad, https://tilleggsstonader-unleash-web.nav.cloud.nais.io/projects/default/features/sak.soknad-routing.tilsyn-barn/variants
Se detaljer i https://docs.getunleash.io/reference/feature-toggle-variants#variant-payload
Vi har en egen unleash på https://tilleggsstonader-unleash-web.nav.cloud.nais.io/
Nais sin dokumentasjon