Tsff 817 tilpasninger fordel #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inavga
commented
Oct 2, 2024
| @@ -72,7 +72,7 @@ public Response oppdaterJournalpost(OppdaterJournalpostRequest oppdaterJournalpo | |||
| } | |||
| var oppdaterJournalpostResponse = new OppdaterJournalpostResponse(); | |||
| oppdaterJournalpostResponse.setJournalpostId(journalpostId); | |||
| return Response.accepted().entity(oppdaterJournalpostResponse).build(); | |||
| return Response.ok().entity(oppdaterJournalpostResponse).build(); | |||
There was a problem hiding this comment.
k9-Fordel feiler om den får 202 her, den venter 200
inavga
commented
Oct 2, 2024
| case "M" -> "MidlertidigJournalført"; | ||
| case "A" -> "Avbrutt"; | ||
| default -> "MidlertidigJournalført"; | ||
| case "J" -> "EndeligJournalført"; |
There was a problem hiding this comment.
Disse hendelsestypene stemte ikke helt med det som står dokumentert, og ble dermed sortert ut i k9-Fordel: https://confluence.adeo.no/display/BOA/Joarkhendelser#
Jeg vet ikke helt hvordan dette vil slå ut på den andre testene, men prøver denne kombinasjonen for nå. Tar gjerne imot forslag til andre konfigurasjoner.
inavga
commented
Oct 2, 2024
| }; | ||
| } | ||
|
|
||
| private BehandlingsTema tilBehandlingsTema(JournalpostModell modell) { | ||
| return switch (modell.getDokumentModellList().isEmpty() ? DokumenttypeId.UDEFINERT : modell.getDokumentModellList().get(0).getDokumentType()) { | ||
| return switch (modell.getDokumentModellList().isEmpty() ? DokumenttypeId.UDEFINERT : modell.getDokumentModellList().getFirst().getDokumentType()) { |
tendestad
approved these changes
Oct 2, 2024
jolarsen
approved these changes
Oct 6, 2024
inavga
force-pushed
the
TSFF-817-tilpasninger-fordel
branch
from
f807989
to
ce40831
Compare
inavga
force-pushed
the
TSFF-817-tilpasninger-fordel
branch
from
ce40831
to
40c2124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.