Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility warning on deploy #43

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

NachoVazquez
Copy link
Contributor

@NachoVazquez NachoVazquez commented Apr 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When deploying an application with the nx-cloudflare plugin we always get a warning from wrangler saying that we didn't set up the compatibility_date on the wrangler.toml which is not correct.

If we deploy directly the warning is not there.

What is the new behavior?

  • uses the latest version of workers
  • can run the deploy command from different places on the project

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NachoVazquez NachoVazquez merged commit 4ff171c into main Apr 20, 2024
4 checks passed
@NachoVazquez NachoVazquez deleted the fix/compatibility-warning-on-deploy branch April 20, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant