Update TodoItems.js #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding in Constructor: You are binding your class methods in the constructor, which is a common practice in class components. However, it might be more convenient and cleaner to use arrow functions for methods in your class. This way, you don't need to bind this context in the constructor. Prop Types: It's a good practice to define propTypes for your components. This helps with validation and makes sure that the props you're expecting are being passed in correctly. Destructuring Props: In the render method, you can destructure the props for cleaner code. Use const instead of var: In modern JavaScript, const or let is preferred over var due to their block scope. Semantic HTML: Use button for delete action as it is more semantic, and it can help with accessibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding in Constructor: You are binding your class methods in the constructor, which is a common practice in class components. However, it might be more convenient and cleaner to use arrow functions for methods in your class. This way, you don't need to bind this context in the constructor.
Prop Types: It's a good practice to define propTypes for your components. This helps with validation and makes sure that the props you're expecting are being passed in correctly.
Destructuring Props: In the render method, you can destructure the props for cleaner code.
Use const instead of var: In modern JavaScript, const or let is preferred over var due to their block scope.
Semantic HTML: Use button for delete action as it is more semantic, and it can help with accessibility.