Services: TorServiceHost to be IDisposable (#41)

The guards should be killed after the TorServiceHost is dead and not functioning. This is achieved by implementing the dispose function. This function should be called by the end user.
nblockchain · Oct 21, 2022 · 51bdb10 · 51bdb10
1 parent 7ad0b22
commit 51bdb10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/NOnion.Tests/HiddenServicesTests.cs b/NOnion.Tests/HiddenServicesTests.cs
@@ -151,6 +151,8 @@ public async Task EstablishAndCommunicateOverHSConnectionOnionStyle()
                 });
 
             await TaskUtils.WhenAllFailFast(serverSide, clientSide);
+
+            ((IDisposable) host).Dispose();
         }
 
         [Test]

diff --git a/NOnion/Services/TorServiceHost.fs b/NOnion/Services/TorServiceHost.fs
@@ -819,3 +819,8 @@ type TorServiceHost
 
     member self.ExportPrivateKey() =
         masterPrivateKey
+
+    interface IDisposable with
+        member __.Dispose() =
+            for guard in guardNode do
+                (guard :> IDisposable).Dispose()