Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: rethrow IOException as NOnionException (Not Tested) #47

Closed

Conversation

parhamsaremi
Copy link

IOExcepion caused problems in geewallet as mentioned in [1]. This commit will fix this problem by catching the IOException and rethrowing it as NOnionException.

I couldn't test this.

[1] #45

IOExcepion caused problem in geewallet as mentioned in [1].
This commit will fix this problem by catching the IOException
and rethrowing it as NOnionException.

[1] nblockchain#45
@aarani
Copy link
Collaborator

aarani commented Nov 9, 2022

I think this whole wrapping thing needs to be done in a more DRY way.
We can't just keep adding catch clauses every place we see an exception because it's getting out of hand.
I suggest we create a WrapGuardExceptions function and use that in every place TorGuard calls to the outside world.
OR something like RunWithExceptionHandling, something like that.

@parhamsaremi
Copy link
Author

I think this whole wrapping thing needs to be done in a more DRY way. We can't just keep adding catch clauses every place we see an exception because it's getting out of hand. I suggest we create a WrapGuardExceptions function and use that in every place TorGuard calls to the outside world. OR something like RunWithExceptionHandling, something like that.

Fixed in #49.

@knocte
Copy link
Member

knocte commented Oct 21, 2023

@aarani can you rebase this please

@aarani
Copy link
Collaborator

aarani commented Oct 21, 2023

@aarani can you rebase this please

No, this PR should've been closed because of #49.

This exception is now handled in master: 258ab3d#diff-6dbe73c45d6afd4c67bff706c6d46175a05a09a75dac6aea932fb7c2342a88acR38

@aarani aarani closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants