Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Nethereum metapackage #4

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

webwarrior-ws
Copy link

Create Nethereum metapackage and publish it on nuget.org.

--property:TargetFrameworks=netstandard2.0 \
--property:Version=$VERSION

- name: Push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webwarrior-ws please add an if here that has three conditions:

  1. checks secrets.NUGET_API_KEY is not empty
  2. checks github.event_name == 'push'
  3. checks github.ref == 'refs/heads/upstream'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Check for presence of secrets.NUGET_API_KEY is made in script
itself, because Github actions don't have access to secrets
context in if statements (see [1]).

[1] https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
@knocte knocte merged commit fc1b47d into nblockchain:upstream Apr 2, 2024
2 checks passed
knocte pushed a commit that referenced this pull request Apr 11, 2024
* GitHubCI: add metapackage push

Following:
https://danielwertheim.se/how-to-create-a-nuget-metapackage/

Co-authored-by: Mehrshad <[email protected]>

* GithubCI: use nugetPreRelease.fsx to get version

* GithubCI: publish package on nuget

* GithubCI: add conditions for "Push" step

Check for presence of secrets.NUGET_API_KEY is made in script
itself, because Github actions don't have access to secrets
context in if statements (see [1]).

[1] https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants