Create Nethereum metapackage #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Apr 1, 2024
| --property:TargetFrameworks=netstandard2.0 \ | ||
| --property:Version=$VERSION | ||
|
|
||
| - name: Push |
There was a problem hiding this comment.
@webwarrior-ws please add an if here that has three conditions:
- checks secrets.NUGET_API_KEY is not empty
- checks github.event_name == 'push'
- checks github.ref == 'refs/heads/upstream'
Check for presence of secrets.NUGET_API_KEY is made in script itself, because Github actions don't have access to secrets context in if statements (see [1]). [1] https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
webwarrior-ws
force-pushed
the
metapackage
branch
from
e0a6d76
to
c5146b5
Compare
knocte
pushed a commit
that referenced
this pull request
Apr 11, 2024
* GitHubCI: add metapackage push Following: https://danielwertheim.se/how-to-create-a-nuget-metapackage/ Co-authored-by: Mehrshad <[email protected]> * GithubCI: use nugetPreRelease.fsx to get version * GithubCI: publish package on nuget * GithubCI: add conditions for "Push" step Check for presence of secrets.NUGET_API_KEY is made in script itself, because Github actions don't have access to secrets context in if statements (see [1]). [1] https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Nethereum metapackage and publish it on nuget.org.