Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts to apply and check the style of F#, C#, TS, YMl and XAML files #103

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add scripts to apply and check the style of F#, C#, TS, YMl and XAML files #103

wants to merge 4 commits into from

Commits on Aug 9, 2023

  1. scripts/styleChecker.fsx: add 

    Add styleChecker.fsx script to check style of our F#, TS and
YML codes.

The `git respore package.json` command in the styleChecker.fsx
script was failing with the following error, even when I was
running the `git config --global --add safe.directory '*'`
command in both the styleChecker.fsx script and in the CI. In
the issue [1], it's suggested by someone to use --system instead
of --global in the mentioned command, when the git command is
running in a container, which solved the problem.

```
fatal: detected dubious ownership in repository at '/__w/conventions/conventions'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/conventions/conventions

Error when running 'git restore package.json'
Fsdk.Process+ProcessFailed: Exception of type 'Fsdk.Process+ProcessFailed' was thrown.
   at Fsdk.Process.ProcessResult.Unwrap(String errMsg)
   at Fsdk.Process.ProcessResult.UnwrapDefault()
   at FSI_0002.RunPrettier(String arguments)
   at <StartupCode$FSI_0002>.$FSI_0002.main@()
Stopped due to error
Error: Process completed with exit code 1.
```

[1] actions/checkout#1048
    @tehraninasab
    tehraninasab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6f8edca View commit details
    Browse the repository at this point in the history

  2. scripts/styleChecker.fsx: check C# & XAML files

    @tehraninasab
    tehraninasab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cde3c84 View commit details
    Browse the repository at this point in the history

  3. scripts/styleChecker.fsx: refactor

    @tehraninasab
    tehraninasab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f57f128 View commit details
    Browse the repository at this point in the history

  4. scripts: split styleChecker script 

    Split styleChecker into styleCheck and styleApply.
    @tehraninasab
    tehraninasab committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6a89659 View commit details
    Browse the repository at this point in the history