commitlint,docs: start using FP patterns #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webwarrior-ws hey Taras can you investigate why the 2nd commit of this PR breaks tests please? I'm very confused. |
|
@knocte you've used class |
|
Thanks |
And make use of it in one of the plugins already. See my SO post about this: https://stackoverflow.com/a/78937127/544947 Co-authored-by: webwarrior <[email protected]>
knocte
force-pushed
the
wip/fp
branch
4 times, most recently
from
65ac82d
to
00f6eef
Compare
Empty classes result in strange issues that turn the TS compiler into not very helpful. E.g.: https://stackoverflow.com/questions/78953267/why-is-typescript-not-throwing-a-compile-time-error-when-constructor-is-not-used NOTE: we still mark the new methods as deprecated to give a hint that `instanceof` usage is better. These tooltips will be properly shown by IDEs and linters according to: https://stackoverflow.com/a/62991642/544947
knocte
force-pushed
the
wip/fp
branch
2 times, most recently
from
05ef34b
to
ef4ddb9
Compare
The keyword `instanceof` is a footgun in JS/TS because it only works for classes, but not primitive types. This was taken from: https://stackoverflow.com/a/58184883/544947
|
There was a bug in |
knocte
force-pushed
the
wip/fp
branch
4 times, most recently
from
73e0062
to
ef97226
Compare
knocte
force-pushed
the
wip/fp
branch
3 times, most recently
from
8576978
to
bcffbc8
Compare
knocte
force-pushed
the
wip/fp
branch
2 times, most recently
from
6807c3d
to
2100e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.