Detect non-verbose flags being used in F# scripts or YML CI files #91
Conversation
tehraninasab
force-pushed
the
detectNonVerboseFlags-squashed
branch
3 times, most recently
from
da363a9
to
daf36a7
Compare
|
Please rebase this PR 🙏 Thanks |
tehraninasab
force-pushed
the
detectNonVerboseFlags-squashed
branch
from
2d5c202
to
7e9f86f
Compare
Done |
knocte
force-pushed
the
master
branch
2 times, most recently
from
d1bd1c2
to
908c11d
Compare
tehraninasab
force-pushed
the
detectNonVerboseFlags-squashed
branch
5 times, most recently
from
8e3f57a
to
021111d
Compare
| assert | ||
| validExtensions | ||
| |> Seq.map(fun ext -> fileInfo.FullName.EndsWith(ext)) | ||
| |> Seq.contains true |
There was a problem hiding this comment.
@realmarv can you explain what exactly are you doing here please? this is a bit unreadable; also, why are you using assert instead of failwith? I'm actually not familiar with assert func TBH, but I have the feeling that it only works in DEBUG mode and the error thrown would be very unreadable (as opposed to using failwith where you are required to provide a readable error)
There was a problem hiding this comment.
@realmarv BTW I just cooked this in case you want to use it: nblockchain/fsx@7acb7a5 (will be available in nuget in 5min)
There was a problem hiding this comment.
It loops over validExtensions sequence and checks if the file path ends with any of them
|
@realmarv I raised 2 nits before this can be merged; but please before addressing them, please pull, because I added a commit to your branch |
knocte
force-pushed
the
detectNonVerboseFlags-squashed
branch
from
3e07e1d
to
765a2c4
Compare
|
@realmarv also PR's CI is red |
Add tests for NonVerboseFlagsInGitHubCI function.
Implement NonVerboseFlagsInGitHubCI function.
Fix NonVerboseFlagsInGitHubCI function.
Cover .sh and .fs files in NonVerboseFlagsInGitHubCI.
Detect non-verbose flags in .yml, .sh, .fs and .fsx files.
Run nonVerboseFlagsInGitHubCIAndFsharpScripts.fsx script and convert non-verbose flags to verbose flags.
tehraninasab
force-pushed
the
detectNonVerboseFlags-squashed
branch
3 times, most recently
from
199cf64
to
4156fa4
Compare
| |> Seq.map(fun ext -> | ||
| Helpers.GetInvalidFiles | ||
| rootDir | ||
| ("*" + ext) |
There was a problem hiding this comment.
@realmarv aren't you missing a dot after * here?
There was a problem hiding this comment.
No ext already has a dot
tehraninasab
force-pushed
the
detectNonVerboseFlags-squashed
branch
from
4156fa4
to
be256d4
Compare
|
CI is still red |
It's green now |
No description provided.