CI,scripts: DRY around git submodules population

.github/workflows/CI.yml

@@ -514,7 +514,7 @@ jobs:
       run: ./configure.sh --native-segwit
     - name: Bump version to beta (because segwit)
       run: |
-        git submodule foreach git fetch --all && git submodule sync --recursive && git submodule update --init --recursive
+        ./scripts/populate_gitsubmodules.sh
         dotnet fsi ./scripts/beta_bump.fsx
     - name: pack&push
       run: make push
@@ -585,7 +585,7 @@ jobs:
 
     - name: Bump snap version
       run: |
-        git submodule foreach git fetch --all && git submodule sync --recursive && git submodule update --init --recursive
+        ./scripts/populate_gitsubmodules.sh
         dotnet fsi ./scripts/beta_bump.fsx
 
     - name: Generate snap package

configure.sh

@@ -14,16 +14,7 @@ else
 
     cp NuGet-legacy.config NuGet.config
 
-    if [ ! -f scripts/fsx/configure.sh ]; then
-        if ! which git >/dev/null 2>&1; then
-            echo "checking for git... not found" $'\n'
-
-            echo "$0" $'failed, please install "git" (to populate submodule) first'
-            exit 1
-        fi
-        echo "Populating sub-fsx module..."
-        git submodule sync --recursive && git submodule update --init --recursive
-    fi
+    ./scripts/populate_gitsubmodules.sh
 
     FSX_CHECK_MSG="checking for fsx..."
     if ! which fsharpi >/dev/null 2>&1; then

scripts/bump.fsx

@@ -260,7 +260,7 @@ let RunUpdateServers () =
 
 
 if not replaceScript.Exists then
-    Console.Error.WriteLine "Script replace.fsx not found, 'fsx' submodule not populated? Please run `git submodule foreach git fetch --all && git submodule sync --recursive && git submodule update --init --recursive`"
+    Console.Error.WriteLine "Script replace.fsx not found, 'fsx' submodule not populated? Please run `populate_gitsubmodules.sh`"
     Environment.Exit 1
 
 GitDiff()

scripts/populate_gitsubmodules.sh

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+if ! which git >/dev/null 2>&1; then
+    echo "checking for git... not found" $'\n'
+
+    echo "$0" $'failed, please install "git" (to populate submodules) first'
+    exit 1
+fi
+echo "Populating git submodules..."
+
+git submodule foreach git fetch --all && git submodule sync --recursive && git submodule update --init --recursive