Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#138 Add cwd template variable #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#138 Add cwd template variable #300

wants to merge 1 commit into from

Conversation

alexandreh2ag
Copy link

Hi!

As discussed here #138, i purpose this PR to add CWD template variable.

Please let me know if i need to add any changes.

@alexandreh2ag
Copy link
Author

Hello @ncabatoff,
It's possible to give me a review of this PR ? 🙏

Thanks
Alexandre

ncabatoff
ncabatoff reviewed Jul 21, 2024
View reviewed changes
proc/read.go Outdated
if p.cwd == "" {
cwd, err := p.Cwd()

if err != nil && strings.Contains(err.Error(), "permission denied") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you can't use errors.Is(err, fs.ErrPermission)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ncabatoff,

You are right, I modified the code.

@alexandreh2ag
Add cwd template variable
dd45a99 
Signed-off-by: alexandreh2ag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandreh2ag @ncabatoff