Mridul Quest 1 Submission

[mridul7ahuja]

Quest Code Review

Quest number completed: [1]
Discord handle: [mridz#5250]

Thanks for a great intro task!

A few doubts regarding the tests:
Why was it necessary to change uint to uint256 even though they should be identical?
Why was it necessary to name the address of the Uniswap Exchange V2 Router as 'router' and not anything else?

[ncitron]

This looks great to me!

For your questions:

1. No real reason for it needing to be named router, we could have named it anything else. The reason the test will fail if you name it anything else though is because router is a public variable. In solidity, all public variables get an automatic external getter function. So in this instance, the getter is called router(). To check if the state variable has been set correctly, we call this getter function, which is why your tests will fail if you do not name it that.
2. Where did you find using uint instead of uint256 would break the tests? Was it in the function signature during the encoding? This would break it since the use of aliased types are disallowed in calls to abi.encodeWithSignature and uint is just an alias for uint256.

[mridul7ahuja]

Yes, you're right I was using the alias in the function signature earlier. Thanks for the detailed explanations!