[FEAT] 프로필 수정, 회원 탈퇴 시 다이얼로그 추가 #42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.alarmy.near.presentation.feature.friendprofileedittor.dialog | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import com.alarmy.near.R | ||
| import com.alarmy.near.presentation.ui.component.dialog.NearBasicDialog | ||
| import com.alarmy.near.presentation.ui.theme.NearTheme | ||
|
|
||
| @Composable | ||
| internal fun SaveConfirmDialog( | ||
| modifier: Modifier = Modifier, | ||
| onDismissRequest: () -> Unit, | ||
| onConfirm: () -> Unit, | ||
| ) { | ||
| NearBasicDialog( | ||
| onDismiss = onDismissRequest, | ||
| body = stringResource(R.string.editor_save_confirm_content), | ||
| dismissButtonText = stringResource(R.string.editor_save_confirm_cancel), | ||
| confirmButtonText = stringResource(R.string.editor_save_confirm_save), | ||
| onDismissButtonClick = onDismissRequest, | ||
| onConfirmButtonClick = onConfirm, | ||
| ) | ||
| } | ||
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun SaveConfirmDialogPreview() { | ||
| NearTheme { | ||
| SaveConfirmDialog( | ||
| onDismissRequest = { }, | ||
| onConfirm = {}, | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.alarmy.near.presentation.feature.myprofile.dialog | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import com.alarmy.near.R | ||
| import com.alarmy.near.presentation.ui.component.dialog.NearOutlinedDialog | ||
| import com.alarmy.near.presentation.ui.theme.NearTheme | ||
|
|
||
| @Composable | ||
| internal fun WithdrawConfirmDialog( | ||
| modifier: Modifier = Modifier, | ||
| onDismissRequest: () -> Unit, | ||
| onConfirm: () -> Unit, | ||
| ) { | ||
| NearOutlinedDialog( | ||
| onDismiss = onDismissRequest, | ||
| title = null, | ||
| body = stringResource(R.string.withdraw_confirm_content), | ||
| dismissButtonText = stringResource(R.string.withdraw_confirm_cancel), | ||
| confirmButtonText = stringResource(R.string.withdraw_confirm_withdraw), | ||
| onDismissButtonClick = onDismissRequest, | ||
| onConfirmButtonClick = onConfirm, | ||
| ) | ||
|
Comment on lines
17
to
25
There was a problem hiding this comment. 현재 NearOutlinedDialog(
onDismiss = onDismissRequest,
title = null,
body = stringResource(R.string.withdraw_confirm_content),
dismissButtonText = stringResource(R.string.withdraw_confirm_cancel),
confirmButtonText = stringResource(R.string.withdraw_confirm_withdraw),
onDismissButtonClick = onDismissRequest,
onConfirmButtonClick = {
onConfirm()
onDismissRequest()
},
) |
||
| } | ||
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun WithdrawConfirmDialogPreview() { | ||
| NearTheme { | ||
| WithdrawConfirmDialog( | ||
| onDismissRequest = { }, | ||
| onConfirm = {}, | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재
onConfirm콜백에서 다이얼로그를 닫는 로직까지 함께 처리하고 있습니다. 다이얼로그가 확인 동작 후 스스로 닫히도록 책임을 위임하면, 호출부의 코드가 더 간결해지고 컴포넌트의 재사용성이 높아집니다.onConfirmButtonClick콜백 내에서onConfirm()실행 후onDismissRequest()를 호출하도록 수정하는 것을 제안합니다. 이렇게 하면FriendProfileEditorScreen에서onConfirm = onSubmit과 같이 더 간단하게 사용할 수 있습니다.