Skip to content

[Fix] 친구 프로필 중첩 스크롤 오류 수정 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhkrwngud445 merged 2 commits into from
Oct 15, 2025
Merged

[Fix] 친구 프로필 중첩 스크롤 오류 수정 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ce58c
fix(FriendProfileScreen): 중첩 스크롤 삭제
rhkrwngud445 Oct 15, 2025
b214347
chore: 버전코드 업
rhkrwngud445 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Near/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ android {
applicationId = "com.alarmy.near"
minSdk = 27
targetSdk = 35
versionCode = 1
versionCode = 2
versionName = "1.0"

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
Expand Down Expand Up @@ -107,7 +107,7 @@ dependencies {

// Splash Screen API
implementation(libs.androidx.core.splashscreen)

// libphonenumber-android for phone number formatting
implementation("io.michaelrocks:libphonenumber-android:9.0.15")
}
Expand Down
4 changes: 2 additions & 2 deletions ...p/src/main/java/com/alarmy/near/presentation/feature/friendprofile/FriendProfileScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ fun FriendProfileScreen(
) {
val currentTabPosition = remember { mutableIntStateOf(0) }
val dropdownState = remember { mutableStateOf(false) }
val scrollState = rememberScrollState()
// val scrollState = rememberScrollState()
Copy link

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

사용하지 않는 코드는 주석 처리하기보다 완전히 삭제하여 코드 가독성을 높이는 것이 좋습니다.


NearFrame(modifier = modifier) {
Box {
Expand All @@ -154,7 +154,7 @@ fun FriendProfileScreen(
Modifier
.align(Alignment.TopStart)
.fillMaxSize()
.verticalScroll(scrollState)
// .verticalScroll(scrollState)
Copy link

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

중첩 스크롤 문제를 해결하기 위해 verticalScroll을 제거하는 것은 올바른 접근입니다. 하지만 이럴 경우 '프로필' 탭의 내용이 화면보다 길어지면 스크롤이 불가능해져 UI가 잘리는 문제가 발생할 수 있습니다.

RecordTab은 LazyVerticalGrid를 사용해 자체 스크롤이 되지만, ProfileTab은 일반 Column이므로 스크롤 기능이 필요합니다.

따라서 이 verticalScroll은 제거하고, ProfileTab 컴포저블 내부의 Column에 verticalScroll(rememberScrollState())를 추가하여 '프로필' 탭이 독립적으로 스크롤되도록 하는 것을 권장합니다. 이렇게 하면 두 탭 모두에서 올바른 스크롤 동작을 보장할 수 있습니다.

.background(NearTheme.colors.WHITE_FFFFFF),
) {
if (recordSuccessDialogState) {
Expand Down