-
Notifications
You must be signed in to change notification settings - Fork 0
[QA] 연락처 외 수정사항 반영 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 18 commits
97e2c5d
525fc6b
2daa449
1bc2ad3
7dc900c
19cf75d
eb7cf4c
d85077a
7f86285
1bf63ed
05ac850
5b178df
767fe0c
761cdaf
7a7334d
39c7efc
b7146ad
6e8b124
02ef857
4479c49
119e70c
00e427c
3160c32
5d6b6dd
a48bbe4
8409fed
3b8db78
2e25c7e
ccf39de
c338a9b
b334b28
b82da4d
3c61c80
3cd540b
0f0ec16
de9c02c
42fabc6
61d61ac
31a0e66
1672ffa
c9c4326
be85484
186e13b
49e421e
2cffb56
a0d5ed0
29bf984
0182de2
f50748b
d6cece2
1e1b2e9
18745a3
59c9ebc
9b28065
7edaef9
dd873cb
cfe415c
477cf7a
ffda528
6cc3111
6657de6
a376cf8
576da85
53cc221
72ac684
1162e18
4e36099
add9b61
b83ad29
ad3cfe9
1f4474b
79651e1
c7ed1aa
8040d8f
576bc85
01267f0
0044d87
3a7bed5
ca872a8
17a5d87
6d99aa7
9501700
d091842
97e3727
d8b4276
5890721
cf86fcd
01694c5
c9ef039
8e9316a
c14476a
5571518
ccdd668
7fcf4f5
24d275f
c02630c
854d4ac
baebe46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -52,7 +52,7 @@ fun FriendProfileEditorUIState.toModel( | |||||
| relation = relation, | ||||||
| contactFrequency = | ||||||
| contactFrequency, | ||||||
| birthday = birthday.value?.replace(".", "-"), | ||||||
| birthday = birthday.value?.replace(".", "."), | ||||||
|
||||||
| birthday = birthday.value?.replace(".", "."), | |
| birthday = birthday.value?.replace(".", "-"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분을 확인해보니 UI에서 보여줄때 변환이 이뤄지기 때문에 서버에 요청을 보낼 때 변환을 한번 더 해주는 것은 어떨까요? 혹은 Date, Timestamp값을 UI에 보여줄때만 변환하고 고유 값은 변경하지 않아도 좋을 것 같습니다!
수정에서 날짜를 변경하여 수정하면 400 Bad Request 로그를 확인할 수 있었습니다 🥲
다른 정보를 변경하여 수정요청을 하면 문제 없이 잘 수정되고 있어요!
스웨거를 확인해보니 다음과 같은 스펙을 가지고 있습니다!
"birthday": "1997-11-19",
"anniversaryList": [
{
"id": 4,
"title": "test2",
"date": "1997-11-19"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 버그 캐치 감사합니다! 400에러가 나고 있었군요😂
말씀주신 방향으로 수정할게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DateTimeFormatter인스턴스를 함수가 호출될 때마다 생성하고 있습니다. 이는 불필요한 객체 생성을 유발하여 성능에 미미한 영향을 줄 수 있습니다. 포매터 인스턴스를 파일 최상단에private const val로 선언하여 재사용하는 것을 권장합니다.