-
Notifications
You must be signed in to change notification settings - Fork 0
[FIX] 튜토리얼 화면 기기별 대응 #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a904979
refactor: OnboardingScreen을 Route와 Screen으로 분리
stopstone dc2cd11
feat: 온보딩 화면 배경 이미지 추가
stopstone 1b8c7dd
feat: NearFrame의 시스템 바 패딩 적용 여부 옵션 추가
stopstone 74df828
refactor: 온보딩 화면 UI 수정
stopstone 1371792
refactor: 온보딩 화면 레이아웃 구조 개선
stopstone 10b21a3
feat: 공용 디바이스 프리뷰 컴포넌트 추가
stopstone 3694850
refactor: NearFrame 시스템 바 패딩 적용 로직 수정
stopstone fca9f85
fix: 온보딩 화면 UI 깨짐 수정
stopstone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 0 additions & 85 deletions
85
...rc/main/java/com/alarmy/near/presentation/feature/onboarding/components/BackgroundArea.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
Near/app/src/main/java/com/alarmy/near/presentation/preview/DevicePreviewSpecs.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package com.alarmy.near.presentation.preview | ||
|
|
||
| import androidx.compose.ui.tooling.preview.PreviewParameterProvider | ||
| import com.alarmy.near.presentation.preview.model.DevicePreviewSpec | ||
|
|
||
| /** | ||
| * 삼성 대표 기기 해상도를 기반으로 Compose 프리뷰에서 사용할 dp 값을 제공합니다. | ||
| */ | ||
| class DevicePreviewParameterProvider : PreviewParameterProvider<DevicePreviewSpec> { | ||
| override val values: Sequence<DevicePreviewSpec> = | ||
| sequenceOf( | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy S21 (FHD+)", | ||
| widthDp = 360, | ||
| heightDp = 800, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy S23 (FHD+)", | ||
| widthDp = 360, | ||
| heightDp = 780, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy S25 (QHD+)", | ||
| widthDp = 412, | ||
| heightDp = 915, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy S23 Ultra (QHD+)", | ||
| widthDp = 411, | ||
| heightDp = 915, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy Z Flip (FHD+)", | ||
| widthDp = 360, | ||
| heightDp = 860, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy Z Fold (QXGA+)", | ||
| widthDp = 600, | ||
| heightDp = 730, | ||
| ), | ||
| DevicePreviewSpec( | ||
| deviceName = "Galaxy A60 (FHD+)", | ||
| widthDp = 360, | ||
| heightDp = 780, | ||
| ), | ||
| ) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
배경 이미지에
ContentScale.FillBounds를 사용하면 기기 화면 비율에 따라 이미지가 왜곡되어 보일 수 있습니다. 이미지의 비율을 유지하면서 화면을 채우려면ContentScale.Crop을 사용하는 것이 좋습니다.Crop은 이미지가 잘릴 수는 있지만, 왜곡되지 않아 더 자연스러운 배경을 제공할 수 있습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gemini의 리뷰대로 Crop은 이미지가 잘릴 수도 있다는 점에서 수정하지 않고 FillBounds로 남겨두겠습니다.