Skip to content

Conversation

@stopstone
Copy link
Contributor

작업 내용

  • 주기 설정 바텀시트에서 선택된 항목의 텍스트 스타일을 B1_16_BOLD에서 B2_14_BOLD로 변경했습니다.
  • Row에 적용되었던 padding을 내부 Text 컴포넌트로 이동하였습니다.

확인 방법

  • presentation.ui.component.bottomsheet CycleSettingBottomSheet에서
                    style =
                        if (isSelected) {
                            NearTheme.typography.B2_14_BOLD
                        } else {
                            NearTheme.typography.B2_14_MEDIUM
                        },

로 변경하였습니다.

- 주기 설정 바텀시트에서 선택된 항목의 텍스트 스타일을 `B1_16_BOLD`에서 `B2_14_BOLD`로 변경했습니다.
- `Row`에 적용되었던 `padding`을 내부 `Text` 컴포넌트로 이동하였습니다.
@gemini-code-assist
Copy link

Summary of Changes

Hello @stopstone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 Pull Request는 주기 설정 바텀시트 내 UI 개선을 목표로 합니다. 선택된 항목의 텍스트 스타일을 "B1_16_BOLD"에서 "B2_14_BOLD"로 변경하여 시각적 일관성을 확보하고, "Row"에 적용되었던 패딩을 "Text" 컴포넌트로 옮겨 컴포넌트의 책임 분리를 명확히 했습니다. 이는 사용자 인터페이스의 가독성과 유지보수성을 향상시킬 것입니다.

Highlights

  • 텍스트 스타일 변경: 주기 설정 바텀시트에서 선택된 항목의 텍스트 스타일을 "B1_16_BOLD"에서 "B2_14_BOLD"로 변경하여 텍스트 크기를 조정했습니다.
  • 패딩 위치 조정: "Row"에 적용되었던 수직 패딩("vertical = 15.dp")을 내부 "Text" 컴포넌트로 이동하여 레이아웃의 유연성을 높였습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@stopstone stopstone merged commit d93d924 into dev Dec 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the CycleSettingBottomSheet.kt file. It refactors the padding application for text elements, moving the vertical = 15.dp padding from the parent container to directly on the Text composable. Additionally, the typography for selected text within the bottom sheet was updated from NearTheme.typography.B1_16_BOLD to NearTheme.typography.B2_14_BOLD.

@stopstone stopstone deleted the qa/contact-cycle-text-style branch December 11, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants