feat(registry): is_community_verified #73
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amityadav0
reviewed
Aug 22, 2023
| fn _is_human(&self, account: &AccountId) -> SBTs { | ||
| if self._is_banned(&account) { | ||
| return vec![]; | ||
| fn _is_human(&self, account: &AccountId, no_skip_ban: bool) -> SBTs { |
There was a problem hiding this comment.
Why do we need no_skip_ban ?
There was a problem hiding this comment.
maybe we can put conditions in one if
There was a problem hiding this comment.
to not repeat that check in case we are coming from is_community_verified
|
Are we going to update flag list to use |
sczembor
reviewed
Aug 22, 2023
| /// If `is_human` is false, then the `is_human` check is skipped and empty list is | ||
| /// returned. Otherwise `is_human` is assumed to be required and if the IAH check fails, | ||
| /// the community verification is skipped (so two empty lists are returned). | ||
| pub fn is_community_verified(&self, account: AccountId, is_human: bool) -> (SBTs, SBTs) { |
There was a problem hiding this comment.
why do we need the is human here?
There was a problem hiding this comment.
to avoid is_human call
sczembor
reviewed
Aug 22, 2023
sczembor
reviewed
Aug 22, 2023
amityadav0
reviewed
Aug 22, 2023
amityadav0
reviewed
Aug 22, 2023
| /// returned. Otherwise `is_human` is assumed to be required and if the IAH check fails, | ||
| /// the community verification is skipped (so two empty lists are returned). | ||
| /// returned. | ||
| /// EXPERIMENTAL: the function API can change in the future. |
There was a problem hiding this comment.
Could you please add here ? Maybe if first SBTs is empty that means it is not community verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graylist is not going to be explicit. Nobody is going to load users to flag them as graylist.
Instead, the definition of graylist is that it's an account without reputation. So we are proposing the following method, that resambles
is_human:is_community_verifiedwhich will return list of proofs that the account has been verified by a community. This is meant to be consistent withis_humanwhich has been proven to be useful.TODO: