-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement is_human_call_lock #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets reuse the existing integration test for migration
Co-authored-by: sczembor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I was thinking about potential shortcomings which may be a dapp setting the lock duration to some crazy long time (let's say a couple of yeas) either by a code bug or on purpose. Maybe there should be a way to release the lock before. The easiest way would be some admin method that can be called or a way for the dapp that the lock comes from to release it (it might be also good for some use cases where the i.e voting ends earlier than expected and the lock can be released).
Left few code suggestions in code mostly docs and comments. Also the integration test for migration is missing
Co-authored-by: sczembor <[email protected]>
I will add a safety check to 2months.
|
This is needed for Voting Body personhood checks.