Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added info about new status codes #2195

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

frolvanya
Copy link
Contributor

This PR is adding an information about new possible status codes that can be returned by jsonrpc

From now on, jsonrpc will start returning other HTTP codes than 200 OK for some errors:

  • On internal server error it will return 500
  • On timeout error it will return 408
  • On request validation error will return 400

Changes were introduced in near/nearcore#11806 and near/nearcore#11822

@frolvanya
Copy link
Contributor Author

@race-of-sloths please, include my PR in the Race

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I realize it might be a bit uncomfortable to scroll the table horizontally, but all the information is here and consumable. Designing the docs is a different sort of task.

@race-of-sloths score 1

Copy link
Contributor

@telezhnaya telezhnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the point that designing the doc is a separate job

LGTM

@bucanero bucanero merged commit 2709161 into near:master Aug 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

4 participants