-
Notifications
You must be signed in to change notification settings - Fork 13
Support omni-bridge token wrapping #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BonelessImpl
wants to merge
60
commits into
main
Choose a base branch
from
feat/poa-support-omni-bridge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ff6e1f
to
b4d41e8
Compare
fusede
requested changes
Mar 25, 2025
mitinarseny
reviewed
Apr 4, 2025
#[cfg(feature = "contract")] | ||
mod contract; | ||
pub mod contract; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remember to add to both: PoA Token & PoA Factory:
impl ControllerUpgradable for Contract {
#[only(self, owner)]
fn upgrade(...) -> Promise { /* ... */}
}
This reverts commit 624c2b6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support omni bridge by wrapping its token with the PoA tokens. This PR supports migrating a token from being used as an owned token, vs being used to wrap omni bridge.
The upgrade takes two steps:
Mandatory initial contract upgrade, which will add a field that contains the target wrapped token as options
After step 1, the token remains as PoA with nothing changes. Once the migration to Omni bridge is done, we set the wrapped token address, which will change the behavior of the smart contract to wrap omni-bridge